Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BRK-1655] Better strict_host_key_checking fix #1655

Merged
merged 2 commits into from
Jun 18, 2020
Merged

[BRK-1655] Better strict_host_key_checking fix #1655

merged 2 commits into from
Jun 18, 2020

Conversation

trevor-vaughan
Copy link
Contributor

  • Take into account that :paranoid is deprecated
  • Take into account that true/false is deprecated for :verify_host_key

@trevor-vaughan
[BRK-1655] Better strict_host_key_checking fix
00f6aca 
* Take into account that :paranoid is deprecated
* Take into account that true/false is deprecated for :verify_host_key
@trevor-vaughan trevor-vaughan requested a review from a team as a code owner June 2, 2020 15:52
highb
highb reviewed Jun 9, 2020
View reviewed changes
lib/beaker/ssh_connection.rb Outdated Show resolved Hide resolved
@trevor-vaughan @highb
Update lib/beaker/ssh_connection.rb
e77274a 
Co-authored-by: Brandon High <highb@users.noreply.github.com>
@highb
Copy link
Contributor

highb commented Jun 9, 2020

If you want to get rid of that verify_host_key: false is deprecated, use :never message while you're modifying this, I believe either https://github.com/puppetlabs/beaker/blob/master/lib/beaker/options/presets.rb#L199 and https://github.com/puppetlabs/beaker/blob/master/lib/beaker/host/cisco.rb#L16 will also need an update or this should also handle the case where verify_host_key is a Boolean.

@highb
Copy link
Contributor

highb commented Jun 9, 2020

This should prevent it from completely failing, though so it's fine if you don't want to deal with that at this moment, too! 😃

@trevor-vaughan
Copy link
Contributor Author

Well, I don't use the Cisco part and I haven't seen any issue outside of that so I'm good

@highb
Copy link
Contributor

highb commented Jun 9, 2020

Hm, looks like the tests failed because a platform is missing. I'll investigate tomorrow.

highb
highb approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@highb highb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed, and I'm happy with the code. I'll merge this now and we can do a release next week. Thanks for the PR!

@highb highb merged commit 5cb5adc into voxpupuli:master Jun 18, 2020
@highb
Copy link
Contributor

highb commented Jun 23, 2020

This has been released in 4.26.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@highb highb highb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trevor-vaughan @highb