(hotfix) Remove single quotes from Unix host file ops #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit single quotes were added around the `mkdir_p` `rm_rf` and `mv` commands in `Beaker::Unix::Exec`. Refer to voxpupuli@a60451c#diff-adecec78dcc971d847136c54308d7766L120 These added single quotes caused interpolation of variables such as `~` for the user HOME to stop working. This commit removes the single quotes added to those command string in the mentioned commit. We can consider adding double quote in the future, although folks may be reliant on shell globbing and other features of not having quotes so we may need to add a parameter to control the behavior.
highb
force-pushed
the
hotfix-remove-single-quoting-around-file-operations-in-exec
branch
from
92b5340
to
6a9495b
Compare
|
Jenkins, test this please |
rooneyshuman
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit single quotes were added around the
mkdir_prm_rfandmvcommands inBeaker::Unix::Exec. Refer to a60451cThese added single quotes caused interpolation of variables such as
~forthe user HOME to stop working.
This commit removes the single quotes added to those command string in
the mentioned commit. We can consider adding double quote in the future,
although folks may be reliant on shell globbing and other features of
not having quotes so we may need to add a parameter to control the
behavior.