Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(BKR-1641) Added chmod and modified_at exec commands #1638

Merged
merged 1 commit into from
May 7, 2020
Merged

(BKR-1641) Added chmod and modified_at exec commands #1638

merged 1 commit into from
May 7, 2020

Conversation

sebastian-miclea
Copy link
Contributor

No description provided.

@sebastian-miclea sebastian-miclea requested a review from a team as a code owner April 23, 2020 11:50
@sebastian-miclea sebastian-miclea changed the title (BKR-1693) Added chmod and modified_at exec commands (BKR-1641) Added chmod and modified_at exec commands Apr 23, 2020
gimmyxd
gimmyxd reviewed Apr 23, 2020
View reviewed changes
spec/beaker/host/unix/file_spec.rb Outdated Show resolved Hide resolved
spec/beaker/host/windows/exec_spec.rb Outdated Show resolved Hide resolved
lib/beaker/host/unix/exec.rb Show resolved Hide resolved
lib/beaker/host/pswindows/file.rb Outdated Show resolved Hide resolved
@gimmyxd
Copy link
Contributor

gimmyxd commented Apr 23, 2020

The failures in acceptance/tests/base.external_resources_test.rb are unrelated as the fedora epel repository is not accessible anymore, giving 404

@sebastian-miclea
Copy link
Contributor Author

The failures in acceptance/tests/base.external_resources_test.rb are unrelated as the fedora epel repository is not accessible anymore, giving 404

I saw that, I've created a PR to remove EPEL5

@sebastian-miclea
Copy link
Contributor Author

Passing build:
https://jenkins-master-prod-1.delivery.puppetlabs.net/view/Adhoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/

@gimmyxd
Copy link
Contributor

gimmyxd commented Apr 29, 2020 •
edited
Loading

Seems like puppet-agent 5.5.13 is not anymore on builds delivery and some tests try to download it 😭

@highb
Copy link
Contributor

highb commented May 6, 2020

Jenkins test this please

@highb
Copy link
Contributor

highb commented May 6, 2020 •
edited
Loading

Seems like puppet-agent 5.5.13 is not anymore on builds delivery and some tests try to download it 😭

Yeah, I think I've fixed up that issue in beaker-puppet. Hopefully this re-run goes green.

@gimmyxd
Copy link
Contributor

gimmyxd commented May 6, 2020 •
edited
Loading

@highb this is also needed since we can't test anymore with legacy puppet and osx-1012: https://github.com/puppetlabs/ci-job-configs/pull/6994

highb
highb approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@highb highb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 New methods look good, adding quotes to prevent globbing in the mkdir/rm/mv commands seems like a sensible change to me.

@highb highb merged commit 5416b0a into voxpupuli:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gimmyxd gimmyxd gimmyxd left review comments

@highb highb highb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastian-miclea @gimmyxd @highb