Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The recent change to the set_host_default method in vagrant_libvirt broke multi-node testing #49

Closed
trevor-vaughan opened this issue May 25, 2021 · 3 comments · Fixed by #50
Closed

The recent change to the set_host_default method in vagrant_libvirt broke multi-node testing #49

trevor-vaughan opened this issue May 25, 2021 · 3 comments · Fixed by #50
Assignees
@trevor-vaughan

Comments

@trevor-vaughan
Copy link
Contributor

https://github.com/voxpupuli/beaker-vagrant/blob/master/lib/beaker/hypervisor/vagrant_libvirt.rb#L36 causes hack_etc_hosts to mangle the /etc/hosts file.
@trevor-vaughan trevor-vaughan self-assigned this May 25, 2021
@trevor-vaughan
Copy link
Contributor Author

@ekohl Can we revert your libvirt changes? They broke pretty much everything about multi-node testing with libvirt.

trevor-vaughan added a commit to trevor-vaughan/beaker-vagrant that referenced this issue May 25, 2021
@trevor-vaughan
Remove set_host_default from vagrant_libvirt
1cfbdcd 
The previous change broke the proper update of /etc/hosts by beaker
which, in turn, broke multi-node testing.

Fixes: voxpupuli#49
@trevor-vaughan trevor-vaughan mentioned this issue May 25, 2021
Merged
@trevor-vaughan
Copy link
Contributor Author

I added a PR that fixes the issue

@trevor-vaughan
Copy link
Contributor Author

@genebean and/or @bastelfreak You up for taking a look at this? Multi-node is broken in libvirt until the PR can go through.

trevor-vaughan added a commit to trevor-vaughan/beaker-vagrant that referenced this issue May 25, 2021
@trevor-vaughan
Remove set_host_default from vagrant_libvirt
1cfc4b6 
The previous change broke the proper update of /etc/hosts by beaker
which, in turn, broke multi-node testing.

Fixes: voxpupuli#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevor-vaughan trevor-vaughan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove set_host_default from vagrant_libvirt trevor-vaughan/beaker-vagrant
1 participant
@trevor-vaughan