Add a check on windows part, to exec commands on a non cygwin environment

[oskar-flores]

When a PSwindows node neither rm nor /dev/null will work. This is a way to fix this (probably not the best one...)

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[DavidS]

Thanks for your contribution! I would suggest putting both alternatives into the if like this:

if node.is_cygwin?
  delete_command = 'rm -f'
  redirection = '< /dev/null'
else
  # ...
end
on node, "#{delete_command} script1.ps"

That cleans up that a little bit. Also adjusting the comment at https://github.com/puppetlabs/beaker-rspec/pull/77/files#diff-befb1733680f635c46fc0aad3de0ba18R248 would be good.

[oskar-flores]

Cleaned up a little bit.

Humm, thinking a little bit, should we change the class name from BeakerCygwin to something more descriptive like, BeakerWindows?

[DavidS]

Renaming the class sounds like a good idea, now that it's not cygwin specific. I hope that nothing depends on the class name.

[kevpl]

@puppetlabs-jenkins test this please

[puppetlabs-jenkins]

Refer to this link for build results (access rights to CI server needed):
http://jenkins-beaker.delivery.puppetlabs.net//job/qe_beaker-rspec_btc-intn-sys/29/
Test PASSed.