Rearrange the cleanup handling #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevor-vaughan
force-pushed
the
cleanup_failed_provisioning
branch
from
2b97314 to
5861669
Compare
This patch moves the INT trap above the system provisioning as well as wrapping the call to `provision` in a rescue block that will avoid further execution. This should fix the issue where container and local VM tests continue to try and run the `provision` stage in the background even if the user wants to cancel all jobs. Cloud providers may need to address the issue in their `cleanup` method specifically.
trevor-vaughan
force-pushed
the
cleanup_failed_provisioning
branch
from
5861669 to
fe5e4f7
Compare
|
@genebean As far as I know this is good to go. Can you let me know what Jenkins is yelling about? |
|
@trevor-vaughan it says two of the requested server types are not available when they are. I am checking on this... |
genebean
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the INT trap above the system provisioning as well as
wrapping the call to
provisionin a rescue block that will avoidfurther execution.
This should fix the issue where container and local VM tests continue to
try and run the
provisionstage in the background even if the userwants to cancel all jobs.
Cloud providers may need to address the issue in their
cleanupmethodspecifically.