Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BKR-1698) Use generic vagrant box for centos6 #203

Closed
wants to merge 1 commit into from

Conversation

wbclark
Copy link

@wbclark wbclark commented Feb 10, 2021

The centos organization on vagrant cloud (htttps://app.vagrantup.com/centos)
no longer provides a centos/6 box. This commit switches to the generic base
boxes for centos which are still available and kept up to date.

@wbclark
Copy link
Author

wbclark commented Feb 12, 2021

I've updated this to preserve the current behavior for centos7 and centos8, and use the generic box for centos6 only

The centos organization on vagrant cloud (htttps://app.vagrantup.com/centos)
no longer provides a centos/6 box. This commit switches to the generic base
boxes for centos which are still available and kept up to date.
@wbclark wbclark changed the title (BKR-1698) Use generic vagrant boxes for centos (BKR-1698) Use generic vagrant box for centos6 Feb 12, 2021
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is wise. CentOS 6 is dead. Do not attempt to keep it alive IMHO. It's not like you still have a mirror network so you can't install anything unless you change it to the non-mirrored vault. The OS is EOL and deserves to die. It's not like we made any effort to keep CentOS 5 alive either.

@wbclark
Copy link
Author

wbclark commented Mar 3, 2021

I don't think this is wise. CentOS 6 is dead. Do not attempt to keep it alive IMHO. It's not like you still have a mirror network so you can't install anything unless you change it to the non-mirrored vault. The OS is EOL and deserves to die. It's not like we made any effort to keep CentOS 5 alive either.

Hey @ekohl , thanks for the review.

I'm in 100% agreement with you when it comes to dropping EL6 support in theforeman/puppet-*. We shouldn't for any reason continue to support it. I would be happy to move forward with that today since it seems we are all onboard.

I am a lot less confident in saying that we should prevent beaker-hostgenerator users from testing against EL6 under any circumstances, given that:

  1. The Centos6 box not only exists at https://app.vagrantup.com/generic/boxes/centos6 but is also still receiving updates (v3.2.6 released 12 days ago, another as yet unreleased version 3.2.8 created 6 hours ago at the time I am writing this)

  2. We can't know the circumstances of every user that might need to develop some puppet modules to manage EL6 systems that they need to maintain for a while longer because of whatever circumstance (that is likely beyond their individual control).

I'm not sure if voxpupuli has any guideline or best practice in this area, and if so then of course I'll defer to it. In the absence of an established rule for dealing with this sort of scenario, my feeling is that the image exists and we shouldn't try to decide for users that they are not allowed to test with it, when the user is much closer to their 'need' or 'business case' for doing so than we are.

@ekohl
Copy link
Member

ekohl commented Mar 3, 2021

1. The Centos6 box not only exists at https://app.vagrantup.com/generic/boxes/centos6 but is also still receiving updates (v3.2.6 released 12 days ago, another as yet unreleased version 3.2.8 created 6 hours ago at the time I am writing this)

These are non-official boxes. They do have changes from official images (in my experience most notably with using Google DNS by default which can break in corporate firewall setups).

I also don't see any changes in https://github.com/lavabit/robox/blob/master/http/generic.centos6.vagrant.ks to use vault as repositories.

2\. We can't know the circumstances of every user that might need to develop some puppet modules to manage EL6 systems that they need to maintain for a while longer because of whatever circumstance (that is likely beyond their individual control).

IMHO the burden is on these users. They can also switch to centos6-64{image=generic/centos6} as a workaround.

I'm not sure if voxpupuli has any guideline or best practice in this area, and if so then of course I'll defer to it. In the absence of an established rule for dealing with this sort of scenario, my feeling is that the image exists and we shouldn't try to decide for users that they are not allowed to test with it, when the user is much closer to their 'need' or 'business case' for doing so than we are.

There are strong proponents of killing anything that's EOL. Generally the project has a hard enough time to support what is still upstream supported and there's little to no capacity for anything EOL. While it hasn't been done here, it may actually mean removing older operating systemes that are no longer supported.

Other workarounds include storing the YAML setfile in the repository with modifications. Remember that beaker-hostgenerator is essentially a templating engine which feeds input to beaker itself.

All in all I think we shouldn't put in any effort to support CentOS 6 when upstream has made it very clear that it should no longer be used by removing it from their mirror network.

@wbclark
Copy link
Author

wbclark commented Mar 3, 2021

OK. Thanks for the explanation @ekohl and I'm satisfied by that reasoning.

While it hasn't been done here, it may actually mean removing older operating systemes that are no longer supported.

In that case should we simply close this PR, or is it preferable to rework it to remove any references to EL6?

@ekohl
Copy link
Member

ekohl commented Mar 3, 2021

I think we should close it. We didn't remove 5 either. If we do decide to clean up, it should be The Great Cleanup IMHO.

@wbclark wbclark closed this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants