-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(BKR-1698) Use generic vagrant box for centos6 #203
Conversation
34a90bc
to
d800047
Compare
I've updated this to preserve the current behavior for centos7 and centos8, and use the generic box for centos6 only |
The centos organization on vagrant cloud (htttps://app.vagrantup.com/centos) no longer provides a centos/6 box. This commit switches to the generic base boxes for centos which are still available and kept up to date.
d800047
to
6b0a2e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is wise. CentOS 6 is dead. Do not attempt to keep it alive IMHO. It's not like you still have a mirror network so you can't install anything unless you change it to the non-mirrored vault. The OS is EOL and deserves to die. It's not like we made any effort to keep CentOS 5 alive either.
Hey @ekohl , thanks for the review. I'm in 100% agreement with you when it comes to dropping EL6 support in I am a lot less confident in saying that we should prevent beaker-hostgenerator users from testing against EL6 under any circumstances, given that:
I'm not sure if voxpupuli has any guideline or best practice in this area, and if so then of course I'll defer to it. In the absence of an established rule for dealing with this sort of scenario, my feeling is that the image exists and we shouldn't try to decide for users that they are not allowed to test with it, when the user is much closer to their 'need' or 'business case' for doing so than we are. |
These are non-official boxes. They do have changes from official images (in my experience most notably with using Google DNS by default which can break in corporate firewall setups). I also don't see any changes in https://github.com/lavabit/robox/blob/master/http/generic.centos6.vagrant.ks to use vault as repositories.
IMHO the burden is on these users. They can also switch to
There are strong proponents of killing anything that's EOL. Generally the project has a hard enough time to support what is still upstream supported and there's little to no capacity for anything EOL. While it hasn't been done here, it may actually mean removing older operating systemes that are no longer supported. Other workarounds include storing the YAML setfile in the repository with modifications. Remember that beaker-hostgenerator is essentially a templating engine which feeds input to beaker itself. All in all I think we shouldn't put in any effort to support CentOS 6 when upstream has made it very clear that it should no longer be used by removing it from their mirror network. |
OK. Thanks for the explanation @ekohl and I'm satisfied by that reasoning.
In that case should we simply close this PR, or is it preferable to rework it to remove any references to EL6? |
I think we should close it. We didn't remove 5 either. If we do decide to clean up, it should be The Great Cleanup IMHO. |
The centos organization on vagrant cloud (htttps://app.vagrantup.com/centos)
no longer provides a centos/6 box. This commit switches to the generic base
boxes for centos which are still available and kept up to date.