-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to beaker 5; Drop Ruby 2.4/2.5/2.6 support #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have enabled branch protection with status checks, but on each individual Ruby version. it's better to have a step that depends on the previous steps. So an example is here:
It depends on the matrix (needs: unit
). So that you can safely make a required check and then you can change the test matrix within a PR without changing the required checks in GH every time you do.
707a31a
to
8f52a47
Compare
@ekohl : the project branch protection expects ruby 2.4, 2.5 and 2.6. is this something i can change in code or do i have to go the branch protection rules and update it there? unclear what is expected to be done here. 😵💫 sry, i'm not a gha pro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to be a GH admin (at least on the repo). I've just modified it, but what I did was:
- Go to Settings
- Go to Branches
- Edit the
master
branch protection - Change
Require status checks to pass before merging
to beTest suite
(and dropped all individual checks) - Save
Now you can see that it only requires the Test / Test suite
check.
thx 🙇 |
fixes: #18