Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to beaker 5; Drop Ruby 2.4/2.5/2.6 support #19

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

rwaffen
Copy link
Member

@rwaffen rwaffen commented Mar 27, 2023

fixes: #18

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have enabled branch protection with status checks, but on each individual Ruby version. it's better to have a step that depends on the previous steps. So an example is here:

https://github.com/voxpupuli/gha-puppet/blob/ccce1fb2a2df9a0b619e522a3f516e7c8a6d20d6/.github/workflows/basic.yml#L97-L103

It depends on the matrix (needs: unit). So that you can safely make a required check and then you can change the test matrix within a PR without changing the required checks in GH every time you do.

beaker-hiera.gemspec Outdated Show resolved Hide resolved
@rwaffen rwaffen force-pushed the 18-update-to-beaker-5 branch from 707a31a to 8f52a47 Compare March 27, 2023 14:41
@rwaffen
Copy link
Member Author

rwaffen commented Mar 27, 2023

@ekohl : the project branch protection expects ruby 2.4, 2.5 and 2.6. is this something i can change in code or do i have to go the branch protection rules and update it there? unclear what is expected to be done here. 😵‍💫

sry, i'm not a gha pro.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to be a GH admin (at least on the repo). I've just modified it, but what I did was:

  • Go to Settings
  • Go to Branches
  • Edit the master branch protection
  • Change Require status checks to pass before merging to be Test suite (and dropped all individual checks)
  • Save

Now you can see that it only requires the Test / Test suite check.

@ekohl ekohl merged commit edd24ff into voxpupuli:master Mar 27, 2023
@rwaffen
Copy link
Member Author

rwaffen commented Mar 27, 2023

thx 🙇
i am able to go there, but was not sure if i'm supposed/allowed to do it. sry, still a bit insecure what i can do, dont want to break something,

@bastelfreak bastelfreak changed the title update to beaker 5 update to beaker 5; Drop Ruby 2.4/2.5/2.6 support Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

update to beaker 5
3 participants