Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Ruby ~> 2.4 #11

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Require Ruby ~> 2.4 #11

merged 1 commit into from
Feb 23, 2021

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 5, 2020

This is what's tested and thus the only thing that can be guaranteed.

This is what's tested and thus the only thing that can be guaranteed.
Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. Puppet 5 (All in One platform) shipped with Ruby 2.4.

But before doing a 1.0.0 release, I think we should put out comms, (maybe via slack and a tweet?), giving enough people time to pin the package if they need to.

@ekohl
Copy link
Member Author

ekohl commented Feb 23, 2021

But before doing a 1.0.0 release, I think we should put out comms, (maybe via slack and a tweet?), giving enough people time to pin the package if they need to.

Discussed via IRC, but this gem was archived by Puppetlabs. I asked them to revive it. It was broken with beaker 4 as well so I doubt there were users. The next release will be a major one anyway.

@ekohl ekohl merged commit 9474e53 into voxpupuli:master Feb 23, 2021
@ekohl ekohl deleted the declare-ruby-version branch February 23, 2021 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants