Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use host_packages helper to reuse logic from beaker #59

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Jan 27, 2022

This new method determines the packages to install while taking the host into account. This means docker and non-docker follow the same logic.

This new method determines the packages to install while taking the host
into account. This means docker and non-docker follow the same logic.
@ekohl ekohl marked this pull request as ready for review January 27, 2022 18:19
@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #59 (e126b70) into master (227b105) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   83.94%   84.00%   +0.05%     
==========================================
  Files           1        1              
  Lines         299      300       +1     
==========================================
+ Hits          251      252       +1     
  Misses         48       48              
Impacted Files Coverage Δ
lib/beaker/hypervisor/docker.rb 84.00% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227b105...e126b70. Read the comment docs.

@ekohl ekohl merged commit dfe3dea into voxpupuli:master Jan 27, 2022
@ekohl ekohl deleted the use-packages_to_install branch January 27, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants