Add Podman Support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found some updates that are needed when running against the system podman instead of rootless. |
trevor-vaughan
force-pushed
the
support_rootless_podman
branch
from
9f58efb to
1a86f10
Compare
trevor-vaughan
force-pushed
the
support_rootless_podman
branch
from
1a86f10 to
39cc977
Compare
trevor-vaughan
added a commit
to trevor-vaughan/rubygem-simp-beaker-helpers
that referenced
this pull request
Jan 20, 2021
* Fixed: * Allow all methods that can safely take SUT arrays to do so * Ensure thta pfact_on returns a Hash if appropriate * Fix container support in copy_to * Added: * Explicitly support podman local and remote in copy_to For full podman support, the following are required: * voxpupuli/beaker-docker#29 * upserve/docker-api#569 SIMP-9131 #close SIMP-9129 #close
genebean
reviewed
Jan 20, 2021
op-ct
added a commit
to simp/rubygem-simp-beaker-helpers
that referenced
this pull request
Jan 20, 2021
* Fixed: * Allow all methods that can safely take SUT arrays to do so * Ensure that pfact_on returns a Hash, if appropriate * Fix container support in copy_to * Added: * Explicitly support podman local and remote in copy_to For full podman support, the following are required: * voxpupuli/beaker-docker#29 * upserve/docker-api#569 SIMP-9131 #close SIMP-9129 #close Co-authored-by: op-ct <chris.tessmer@onyxpoint.com>
trevor-vaughan
force-pushed
the
support_rootless_podman
branch
2 times, most recently
from
08f4f07 to
4d0411c
Compare
genebean
approved these changes
Feb 9, 2021
* Fixed
* Validated support for podman in root and rootless mode
* Requires upserve/docker-api#569
* Changed the acceptance nodesets to centos so that testing on both
podman and docker will function properly
* No longer start containers in privileged mode by default for safety
reasons
* Updated the README
* Fixed support for connections to socket files
* Added a check for detection of SSH ports < 1024 if operating in
rootless mode
* Ensure that the IP is set to 127.0.0.1 instead of 0.0.0.0 for better
SSH connections
* Override host.reboot so that containers are not accidentally
destroyed
* Fixed PAM session entries due to known pam_loginuid issues
* Override enable_root_login since it is already performed by
this plugin
* Override ssh_service retart if the init process is set as sshd since
that causes container termination
* Added
* Migrated to support docker-api 2.X
* Set container names as `beaker-<hostname>-<uniquehash>` for easy
cleanup if a name is not otherwise specified and easy identification
when debuggin
* Ensure that the underlying container object can be accessed at any
time through `host[:docker_container]` for selective optimization
* May want to override the archive_to and scp_to/from methods to
call the underlying docker-api commands at some point
trevor-vaughan
force-pushed
the
support_rootless_podman
branch
from
4d0411c to
9d36b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman and docker will function properly
reasons
rootless mode
SSH connections
destroyed
this plugin
that causes container termination
beaker-<uniquehash>for easy cleanup if aname is not otherwise specified
time through
host[:docker_container]for selective optimizationcall the underlying docker-api commands at some point