Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Amazon Linux 2023 #123

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Support Amazon Linux 2023 #123

merged 1 commit into from
Mar 14, 2024

Conversation

treydock
Copy link
Contributor

No description provided.

@treydock
Copy link
Contributor Author

Marking as draft while I validate with some modules that need to support Amazon 2023.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (895bc0a) 86.37% compared to head (079d44c) 86.37%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   86.37%   86.37%           
=======================================
  Files           1        1           
  Lines         279      279           
=======================================
  Hits          241      241           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@treydock
Copy link
Contributor Author

This won't work for all cases until puppetlabs/beaker-puppet@6063d22 is tagged.

@treydock treydock marked this pull request as ready for review January 25, 2024 14:46
@treydock
Copy link
Contributor Author

This is working. https://github.com/OSC/puppet-module-openondemand/actions/runs/7656172797/job/20863882254

The job itself is failing but that's because the RPM repos I'm testing against don't yet exist but the beaker parts to bootstrap the tests are working for Amazon 2023.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this one, but looks good.

@ekohl ekohl merged commit 8e2e571 into voxpupuli:master Mar 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants