(PUP-9212) Allow for image entry point CMDs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a user could choose between running from their own custom entrypoint or running from the default ssh CMD. This made it probelmatic for users wanting to use the default entrypoint for on image while also having ssh running in the container. This change allows a user to set 'use_image_entry_point' for a host; this will use the image's own default CMD and load ssh after the image has started, so that Beaker's DSL can still communicate with the container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, a user could choose between running from their own
custom entrypoint or running from the default ssh CMD. This made it
probelmatic for users wanting to use the default entrypoint for on image
while also having ssh running in the container.
This change allows a user to set 'use_image_entry_point' for a host;
this will use the image's own default CMD and load ssh after the image
has started, so that Beaker's DSL can still communicate with the
container.