-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Structure is fine. I just felt like leaving general comments about the README 😄
|
||
Please see [the events package readme](./events/README.md) for information on how to run the app locally. | ||
The following steps will quickly get you started testing the Dolby.io Communications APIs capabilities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't this need line IMO
|
||
As you browse through the source code and documents, you might come across some of these terms | ||
|
||
* **A host** is a participant with additional permissions to manage the conference and other participants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While technically true, I think it'd be more useful to describe the actions a host can do such as send/receive audio/video, screen sharing, starting the stream etc.
Also, should we replace usages of "conference" with "event"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean you're right - I copied them from our solutions guide. Let me amend them
|
||
* **A host** is a participant with additional permissions to manage the conference and other participants. | ||
* **A viewer** is a participant who can only receive video and audio stream from the conference. | ||
* A **proxy-app-server** is an intermediary API server that communicates with the Dolby.io Communications Platform in order to provide functionality such as RTS/RTMP/HLS streaming or consuming web-hook data. You can see our sample implementation [here](./backend). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proxy-app-server - do we actually use this exact term (hyphens included) anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, I've unhyphenated it. We do refer to Proxy App Server a fair bit.
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
No description provided.