Skip to content
This repository has been archived by the owner on Aug 30, 2024. It is now read-only.

Re-do read me structure #18

Merged
merged 15 commits into from
Jun 8, 2023
Merged

Re-do read me structure #18

merged 15 commits into from
Jun 8, 2023

Conversation

dubeyShivank
Copy link
Contributor

No description provided.

Copy link
Contributor

@tommydolby tommydolby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure is fine. I just felt like leaving general comments about the README 😄


Please see [the events package readme](./events/README.md) for information on how to run the app locally.
The following steps will quickly get you started testing the Dolby.io Communications APIs capabilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't this need line IMO

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved

As you browse through the source code and documents, you might come across some of these terms

* **A host** is a participant with additional permissions to manage the conference and other participants.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While technically true, I think it'd be more useful to describe the actions a host can do such as send/receive audio/video, screen sharing, starting the stream etc.

Also, should we replace usages of "conference" with "event"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean you're right - I copied them from our solutions guide. Let me amend them


* **A host** is a participant with additional permissions to manage the conference and other participants.
* **A viewer** is a participant who can only receive video and audio stream from the conference.
* A **proxy-app-server** is an intermediary API server that communicates with the Dolby.io Communications Platform in order to provide functionality such as RTS/RTMP/HLS streaming or consuming web-hook data. You can see our sample implementation [here](./backend).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proxy-app-server - do we actually use this exact term (hyphens included) anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I've unhyphenated it. We do refer to Proxy App Server a fair bit.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dubeyShivank and others added 13 commits June 9, 2023 09:31
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
Co-authored-by: tommydolby <125934604+tommydolby@users.noreply.github.com>
@dubeyShivank dubeyShivank merged commit aac24b4 into main Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants