Skip to content

Commit

Permalink
Remove unused parameter from place_seam method (SoftFever#6421)
Browse files Browse the repository at this point in the history
  • Loading branch information
vovodroid authored Aug 18, 2024
1 parent 12c4ff0 commit 2acd858
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions src/libslic3r/GCode.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4493,8 +4493,7 @@ std::string GCode::extrude_loop(ExtrusionLoop loop, std::string description, dou
float seam_overhang = std::numeric_limits<float>::lowest();
if (!m_config.spiral_mode && description == "perimeter") {
assert(m_layer != nullptr);
bool is_outer_wall_first = m_config.wall_sequence == WallSequence::OuterInner;
m_seam_placer.place_seam(m_layer, loop, is_outer_wall_first, this->last_pos(), seam_overhang);
m_seam_placer.place_seam(m_layer, loop, this->last_pos(), seam_overhang);
} else
loop.split_at(last_pos, false);

Expand Down
2 changes: 1 addition & 1 deletion src/libslic3r/GCode/SeamPlacer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1486,7 +1486,7 @@ void SeamPlacer::init(const Print &print, std::function<void(void)> throw_if_can
}
}

void SeamPlacer::place_seam(const Layer *layer, ExtrusionLoop &loop, bool external_first,
void SeamPlacer::place_seam(const Layer *layer, ExtrusionLoop &loop,
const Point &last_pos, float& overhang) const {
using namespace SeamPlacerImpl;
const PrintObject *po = layer->object();
Expand Down
2 changes: 1 addition & 1 deletion src/libslic3r/GCode/SeamPlacer.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class SeamPlacer {

void init(const Print &print, std::function<void(void)> throw_if_canceled_func);

void place_seam(const Layer *layer, ExtrusionLoop &loop, bool external_first, const Point &last_pos, float& overhang) const;
void place_seam(const Layer *layer, ExtrusionLoop &loop, const Point &last_pos, float& overhang) const;
private:
void gather_seam_candidates(const PrintObject *po, const SeamPlacerImpl::GlobalModelInfo &global_model_info);
void calculate_candidates_visibility(const PrintObject *po,
Expand Down

0 comments on commit 2acd858

Please sign in to comment.