Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cypress v10.2.0 #1615

Closed
carolinemodic opened this issue Mar 21, 2022 · 4 comments · Fixed by #2189
Closed

Upgrade to cypress v10.2.0 #1615

carolinemodic opened this issue Mar 21, 2022 · 4 comments · Fixed by #2189

Comments

@carolinemodic
Copy link
Contributor

No description provided.

@eventualbuddha
Copy link
Collaborator

I tried the Dockerfile in this comment: cypress-io/cypress#4478 (comment). It did successfully build, though it's a newer version of cypress than we're using. In theory we can build an older version using something similar, or update our cypress version to use the latest. The question then remains how we want to set this up for local development. Could just be a build script that installs and configures it, though that's a decent amount of work.

@taravancil
Copy link
Contributor

To help us decide how to prioritize this: #1684 updates our CircleCI config to save Cypress artifacts which will make it much easier to debug failures in CI. We should definitely still do this work, but maybe it's not as urgent now that we can more easily debug cypress failures in CI.

@carolinemodic carolinemodic self-assigned this May 23, 2022
@carolinemodic
Copy link
Contributor Author

This is solved by cypress-io/cypress#22252, which I have tested locally, you can check out the pre-release binary following the steps in that PR. It will walk you through some automated conversion steps to upgrade to cypress v10 in order to work with the most recent code. If you are running in election-manager there are other issues with the plugins file where you have to change the imports to requires...

@carolinemodic carolinemodic changed the title Investigate how we can develop/iterate on cypress tests locally Upgrade to cypress v10.2.0 Jun 30, 2022
@carolinemodic carolinemodic removed their assignment Jun 30, 2022
@carolinemodic
Copy link
Contributor Author

This is now released as of cypress v10.2.0

eventualbuddha added a commit that referenced this issue Jul 21, 2022
Also stops depending on the `/#demo` URL, which means we can remove `DemoApp` after this lands.

Refs #1615
eventualbuddha added a commit that referenced this issue Jul 21, 2022
Also stops depending on the `/#demo` URL, which means we can remove `DemoApp` after this lands.

Refs #1615
eventualbuddha added a commit that referenced this issue Jul 21, 2022
Also stops depending on the `/#demo` URL, which means we can remove `DemoApp` after this lands.

Refs #1615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants