Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differentiate logged-in status from in-progress status #2089

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

kshen0
Copy link
Contributor

@kshen0 kshen0 commented Dec 4, 2024

#2065

Updates Logged in status to be a different color than the various In progress statuses. The latter is now GOLD1/GOLD4 in Blueprint upon which Arlo's design system is based. Logged in used to use the warning Intent that In progress also uses. warning uses orange per Blueprint docs.

I didn't want to get into changing the vendored design system so I added a non-standard alert intent on the Arlo component that needs it. The non-standard intent is filtered out so we don't pass it as an invalid prop to the underlying Blueprint components.

Screenshot 2024-12-03 at 3 57 40 PM

@kshen0 kshen0 requested a review from jonahkagan December 4, 2024 00:07
@jonahkagan
Copy link
Contributor

I think the gold and orange are too similar to be reliably distinguished.

@kshen0
Copy link
Contributor Author

kshen0 commented Dec 4, 2024

I think the gold and orange are too similar to be reliably distinguished.

The options if staying within the design system are somewhat slim. There's a learned pattern that some colors don't come before orange when denoting status (eg. green). IMO yellow is the natural choice to precede orange but I see how it could be difficult to tell them apart.

I ruled out blue and red for any status because of their connotations with electoral college maps. We could do something like purple or indigo for "Logged in", which would make the progression:
white > grey > purple > orange > green

Purple feels distinct enough from the other colors and not traditionally associated with status that it wouldn't be confusing to put purple before orange, though it might not be very intuitive either.

We could also make Logged in == orange and change In progress to cerulean, turqouise, or lime as an "almost green but not quite". I didn't want to change the meaning of the colors too much during peak audit season but it's probably safer to do that now.

@kshen0
Copy link
Contributor Author

kshen0 commented Dec 4, 2024

Playing around with this more, the most logical thing seems to be changing Logged in to be orange and In progress to be one of blue or purple. The progress of orange > blue > green felt most understandable (purple felt like it was out of left field). Since we already use red for Upload error, I don't feel too bad about using blue for another status.

Screenshot 2024-12-03 at 6 11 46 PM

Using lime, turquoise, and cobalt all had too little contrast with green. Of course we can also go outside the design system for more flexibility but possibly less cohesion.

Copy link
Contributor

@jonahkagan jonahkagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blue looks good to me!

@kshen0 kshen0 force-pushed the kevin/differentiate-logged-in-status branch from e908cd0 to 66b8e5e Compare December 4, 2024 21:25
@kshen0 kshen0 merged commit 90ad5a8 into main Dec 4, 2024
5 checks passed
@kshen0 kshen0 deleted the kevin/differentiate-logged-in-status branch December 4, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants