Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Minor refactor #712

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Minor refactor #712

merged 5 commits into from
Jun 9, 2021

Conversation

JensWehner
Copy link
Member

A collection of small refactors, most major is to rework the complicated jobfile reading from iqm.

@JensWehner
Copy link
Member Author

@votca-bot format

@JensWehner
Copy link
Member Author

@votca-bot changelog: reworked iqm statefile reading

Copy link
Member

@felipeZ felipeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is so much joy in adding constness to objects!

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #712 (d5b87cc) into master (c10508e) will increase coverage by 0.0%.
The diff coverage is 21.8%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #712   +/-   ##
======================================
  Coverage    51.3%   51.3%           
======================================
  Files         292     292           
  Lines       27162   27148   -14     
======================================
- Hits        13950   13949    -1     
+ Misses      13212   13199   -13     
Impacted Files Coverage Δ
include/votca/xtp/segmentmapper.h 57.1% <ø> (ø)
src/libxtp/gwbse/gwbse.cc 0.0% <0.0%> (ø)
src/libxtp/jobcalculators/iqm.cc 0.0% <0.0%> (ø)
src/libxtp/jobcalculators/iqm.h 0.0% <ø> (ø)
src/libxtp/jobcalculators/qmmm.cc 0.0% <0.0%> (ø)
src/libxtp/qmstate.cc 60.6% <100.0%> (-0.6%) ⬇️
src/libxtp/segmentmapper.cc 70.3% <100.0%> (ø)
include/votca/xtp/qmstate.h 86.4% <0.0%> (+2.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c10508e...d5b87cc. Read the comment docs.

@JensWehner JensWehner enabled auto-merge June 9, 2021 13:31
@JensWehner JensWehner merged commit de94367 into master Jun 9, 2021
@JensWehner JensWehner deleted the minor_refactor branch June 9, 2021 15:27
votca-bot added a commit to votca/votca that referenced this pull request Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants