Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

add command line option #711

Merged
merged 4 commits into from
Jun 1, 2021
Merged

add command line option #711

merged 4 commits into from
Jun 1, 2021

Conversation

JensWehner
Copy link
Member

@JensWehner JensWehner commented Jun 1, 2021

add command line option for gpus to xtp.

The implementation is not perfect, basically I use sort of a global variable, but in some sense OPENMP does the same, so maybe it is okay at least for now.

@JensWehner JensWehner requested a review from felipeZ June 1, 2021 14:15
@JensWehner
Copy link
Member Author

@votca-bot format

@JensWehner
Copy link
Member Author

@votca-bot changelog: add command line option for number of gpus

src/libxtp/openmp_cuda.cc Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #711 (26c3011) into master (649f3ce) will decrease coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #711     +/-   ##
========================================
- Coverage    51.3%   51.3%   -0.1%     
========================================
  Files         292     292             
  Lines       27156   27162      +6     
========================================
  Hits        13950   13950             
- Misses      13206   13212      +6     
Impacted Files Coverage Δ
include/votca/xtp/openmp_cuda.h 100.0% <ø> (+16.6%) ⬆️
src/libxtp/openmp_cuda.cc 93.6% <0.0%> (-6.4%) ⬇️
src/libxtp/xtpapplication.cc 36.3% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98cbe84...26c3011. Read the comment docs.

src/libxtp/openmp_cuda.cc Outdated Show resolved Hide resolved
@JensWehner JensWehner enabled auto-merge June 1, 2021 21:41
@JensWehner JensWehner merged commit c10508e into master Jun 1, 2021
@JensWehner JensWehner deleted the gpu_cli branch June 1, 2021 22:45
votca-bot added a commit to votca/votca that referenced this pull request Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants