This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
changed tokenizer interface #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@votca-bot format |
|
@votca-bot changelog: adapted tokenizer api |
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
========================================
- Coverage 51.2% 51.1% -0.1%
========================================
Files 294 294
Lines 26847 27269 +422
========================================
+ Hits 13760 13961 +201
- Misses 13087 13308 +221
Continue to review full report at Codecov.
|
felipeZ
approved these changes
May 11, 2021
| tools::Tokenizer tok_md_atoms(frag.get("mdatoms").as<std::string>(), " \t\n"); | ||
| std::vector<std::string> md_atoms = tok_md_atoms.ToVector(); | ||
| std::vector<std::string> map_atoms = | ||
| frag.get(_mapatom_xml["atoms"]).template as<std::vector<std::string>>(); |
There was a problem hiding this comment.
I don't understand the use of the template keyword here :)
There was a problem hiding this comment.
It is used to indicate that the next < is not a comparison operator but a template parameter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.