This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Implementing extensions to the cudamatrix class #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@votca-bot format |
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
======================================
Coverage 53.3% 53.3%
======================================
Files 296 296
Lines 28064 28064
======================================
Hits 14978 14978
Misses 13086 13086
Continue to review full report at Codecov.
|
|
@votca-bot changelog: added transpose to CudaMatrix |
felipeZ
reviewed
Jan 25, 2021
| @@ -197,8 +197,8 @@ void OpenMP_CUDA::A_TDA(const Eigen::MatrixXd& matrix, | |||
| temp_[threadid].B->copy_to_gpu(matrix); | |||
| cuda_pips_[threadid]->diag_gemm(*temp_[threadid].B, *temp_[threadid].A, | |||
| *temp_[threadid].C); | |||
| cuda_pips_[threadid]->gemm(*temp_[threadid].B, *temp_[threadid].C, | |||
There was a problem hiding this comment.
The new syntax is easier to follow 👍
|
@votca-bot format |
…nto cudamatrix_extension
|
@felipeZ could you have a look again |
felipeZ
approved these changes
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a bit more Eigen like calculations, although not even close to the same extend.
For
gemmcalls it allows to use eitherblock()ortranspose()on some of thecudamatricesThis is nowhere near a complete set of functionality, but it is a start. I would like to get this merged as a small step.