Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Gaussian checkpoint writer #649

Merged
merged 27 commits into from
Jan 20, 2021
Merged

Gaussian checkpoint writer #649

merged 27 commits into from
Jan 20, 2021

Conversation

rubengerritsen
Copy link
Collaborator

@rubengerritsen rubengerritsen commented Jan 18, 2021

A new tool that converts a .orb file to a .fchk (formatted gaussian checkpoint) file, fix #617.

The file specification for the .fchk file on the Gaussian website is very limited, the email from the gaussian people helped a bit, but also didn't contain everything I needed. What I did to get the order, multipliers etc. right is run a dft calculation with psi4, run exactly the same calculation with xtp and compare the votca generated .fchk file with the .fchk output file of psi4. Hence if the psi4 implementation is correct, this one is as well. I couldn't think of any other way to verify the correctness of the implementation. If someone has a good idea please let me know.

Also I still need to add a unit test.

@rubengerritsen
Copy link
Collaborator Author

@votca-bot format

@junghans
Copy link
Member

@votca-bot copyright

Copy link
Member

@JensWehner JensWehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks and add a test pls. I am not fully sure how to best test this. We probably should have a function in tools which compares two files for equality.

src/libxtp/gaussianwriter.cc Show resolved Hide resolved
src/libxtp/gaussianwriter.cc Outdated Show resolved Hide resolved
src/libxtp/gaussianwriter.cc Show resolved Hide resolved
src/libxtp/tools/orb2fchk.cc Show resolved Hide resolved
src/libxtp/gaussianwriter.cc Show resolved Hide resolved
rubengerritsen and others added 2 commits January 19, 2021 14:33
Co-authored-by: Jens <jenswehner@gmail.com>
Co-authored-by: Jens <jenswehner@gmail.com>
@JensWehner
Copy link
Member

@votca-bot changelog: implement fchk writer

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Merging #649 (9900a92) into master (e549fe0) will increase coverage by 0.2%.
The diff coverage is 87.8%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #649     +/-   ##
========================================
+ Coverage    53.1%   53.3%   +0.2%     
========================================
  Files         292     296      +4     
  Lines       27867   28064    +197     
========================================
+ Hits        14798   14978    +180     
- Misses      13069   13086     +17     
Impacted Files Coverage Δ
src/libxtp/tools/mol2orb.h 0.0% <ø> (ø)
src/libxtp/tools/orb2fchk.cc 0.0% <0.0%> (ø)
src/libxtp/tools/orb2fchk.h 0.0% <0.0%> (ø)
src/libxtp/tools/orb2mol.h 0.0% <ø> (ø)
src/tools/xtp_tools.cc 26.5% <0.0%> (ø)
src/libxtp/gaussianwriter.cc 98.2% <98.2%> (ø)
include/votca/xtp/aobasis.h 91.6% <100.0%> (+5.9%) ⬆️
include/votca/xtp/gaussianwriter.h 100.0% <100.0%> (ø)
src/libxtp/factories/toolfactory.cc 100.0% <100.0%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e549fe0...9900a92. Read the comment docs.

@JensWehner
Copy link
Member

@votca-bot format

@rubengerritsen
Copy link
Collaborator Author

@votca-bot format

@JensWehner JensWehner merged commit 780afc5 into master Jan 20, 2021
@JensWehner JensWehner deleted the gaussianCheckpointWriter branch January 20, 2021 19:12
votca-bot added a commit to votca/votca that referenced this pull request Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tool for writing Gaussian formatted checkpoint file
4 participants