libecpint integration #588
Conversation
|
Let's see if we have it everywhere. |
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
========================================
- Coverage 53.2% 51.2% -2.0%
========================================
Files 296 294 -2
Lines 27937 26759 -1178
========================================
- Hits 14866 13722 -1144
+ Misses 13071 13037 -34
Continue to review full report at Codecov.
|
|
Works now, @rubengerritsen @JensWehner I leave the actual work for you guys! |
|
@junghans Thanks for the help. We will make it work. :) |
|
@votca-bot format |
|
@votca-bot copyright |
|
this works locally but atm is blocked by robashaw/libecpint#26 |
|
I think that is the libecpint memory leak |
|
@votca-bot format |
|
@rubengerritsen As the new libecpint release is up, this can be merged soon. Do you want to review? |
|
@votca-bot format |
Co-authored-by: Christoph Junghans <junghans@votca.org>
Co-authored-by: Christoph Junghans <junghans@votca.org>
| @@ -50,6 +50,13 @@ pkg_check_modules(LIBXC REQUIRED IMPORTED_TARGET libxc) | |||
| if(NOT TARGET PkgConfig::LIBINT) | |||
| pkg_check_modules(LIBINT REQUIRED IMPORTED_TARGET libint2>=2.6) | |||
| endif() | |||
| find_package(ecpint REQUIRED) | |||
There was a problem hiding this comment.
Not right now, but later (next week?), we should required version 1.5 here.
There was a problem hiding this comment.
1.0.5? Actually we should require it now, because all the tests segfault otherwise.
There was a problem hiding this comment.
Well, fedora and opensuse didn't receive the 1.0.5 package yet. https://bodhi.fedoraproject.org/updates/FEDORA-2021-5464f657f7 will need 7 more days.
There was a problem hiding this comment.
But Fedora and openSUSE have v1.0.4 with your patch.
There was a problem hiding this comment.
Ok, there is another bug in libecpint (see /robashaw/libecpint/issues/31), that prevents it from exporting the right version in the cmake target, so there is nothing we can right now.
There was a problem hiding this comment.
We can required 1.0.6 once robashaw/libecpint#32 is through. ;-)
|
@rubengerritsen this can be reviewed. :) |
Ultimately fix #567