Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

removed unused option #372

Merged
merged 4 commits into from
Jun 10, 2021
Merged

removed unused option #372

merged 4 commits into from
Jun 10, 2021

Conversation

JensWehner
Copy link
Member

No description provided.

@JensWehner JensWehner requested a review from junghans May 27, 2021 15:05
@JensWehner
Copy link
Member Author

@votca-bot format

@@ -66,7 +66,6 @@ int Application::Exec(int argc, char **argv) {
AddProgramOptions()("verbose1", " be very loud and noisy");
AddProgramOptions()("verbose2,v", " be extremly loud and noisy");
AddProgramOptions("Hidden")("man", " output man-formatted manual pages");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the man option used at all?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you use that for something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we use that new votca_help2doc script everywhere now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that converts the man files to sth else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only uses the output of --help.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow then we can remove quite a bit of stuff. :)

@JensWehner
Copy link
Member Author

@votca-bot changelog: removed tex option

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #372 (5fc02c3) into master (d0b4c00) will increase coverage by 0.0%.
The diff coverage is 0.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #372   +/-   ##
======================================
  Coverage    80.0%   80.1%           
======================================
  Files          77      77           
  Lines        3577    3575    -2     
======================================
- Hits         2865    2864    -1     
+ Misses        712     711    -1     
Impacted Files Coverage Δ
include/votca/tools/propertyiomanipulator.h 21.7% <ø> (ø)
src/libtools/application.cc 51.4% <0.0%> (-1.9%) ⬇️
include/votca/tools/objectfactory.h 100.0% <0.0%> (+9.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b4c00...5fc02c3. Read the comment docs.

@JensWehner JensWehner enabled auto-merge June 9, 2021 11:35
@JensWehner JensWehner requested a review from junghans June 10, 2021 07:03
@JensWehner
Copy link
Member Author

@junghans can you review again

@JensWehner JensWehner merged commit 036289a into master Jun 10, 2021
@JensWehner JensWehner deleted the application_fix branch June 10, 2021 13:01
votca-bot added a commit to votca/votca that referenced this pull request Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants