Skip to content
This repository has been archived by the owner on Sep 27, 2021. It is now read-only.

Fix unique_ptrs #654

Merged
merged 4 commits into from
Feb 13, 2021
Merged

Fix unique_ptrs #654

merged 4 commits into from
Feb 13, 2021

Conversation

JoshuaSBrown
Copy link
Contributor

Fix memory leaks part 4

JensWehner
JensWehner reviewed Feb 11, 2021
View reviewed changes
src/libcsg/topology.cc Outdated Show resolved Hide resolved
JensWehner
JensWehner suggested changes Feb 11, 2021
View reviewed changes
Copy link
Member

@JensWehner JensWehner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use make_unique
otherwise good work

@junghans junghans requested a review from JensWehner February 12, 2021 16:43
@junghans
Copy link
Member

@JensWehner please review again!

JensWehner
JensWehner approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@JensWehner JensWehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

@JensWehner JensWehner merged commit 8e81fba into master Feb 13, 2021
@JensWehner JensWehner deleted the JoshuaSBrown/boundaryconditions_to_unique_ptr branch February 13, 2021 00:24
votca-bot added a commit to votca/votca that referenced this pull request Feb 13, 2021
@votca-bot
Update csg submodule (votca/csg#654)
8eed52c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JensWehner JensWehner JensWehner approved these changes

Assignees
No one assigned
Labels
memory refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoshuaSBrown @junghans @JensWehner