Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

fix propane/imc and add propane/imc-ibiintra #140

Closed
wants to merge 27 commits into from

Conversation

marvinbernhardt
Copy link
Contributor

No description provided.

@junghans
Copy link
Member

Can we keep the file name settings.xml as otherwise CMake won't pick it up as a test.

@junghans
Copy link
Member

In other case we made a pre directory e.g. ./urea-water/cibi/pre`

@marvinbernhardt
Copy link
Contributor Author

In other case we made a pre directory e.g. ./urea-water/cibi/pre`

will do that

@marvinbernhardt marvinbernhardt marked this pull request as ready for review July 23, 2021 13:44
@marvinbernhardt
Copy link
Contributor Author

I think the checks will pass when votca/csg#696 is merged.

@marvinbernhardt
Copy link
Contributor Author

I'm trying to reproduce this at home. Both with my local build and in the fedora:gmx2019_d docker container. In both cases it is two different regression tests that fail

  • regression_methanol_imc
  • regression_propane_imc-ibiintra

and both fail due to low sampled IMC matrix which leads to noisy potentials and gmx mdrun crashing.

What am I missing? Why is the pre-run (IBI) failing in the CI?

@junghans
Copy link
Member

junghans commented Aug 4, 2021

The IMC test were always a bit brittle, we might need to increase the number of steps for the tests (in CMake). I still wondering why the CI passed though.

@marvinbernhardt
Copy link
Contributor Author

I started a re-run

@junghans
Copy link
Member

Replaced by votca/votca#821

@junghans junghans closed this Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants