more robust mu sigma calculation, new seeing function, memory improvements, typo fixes #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bit of a mixed bag for this one. the main changes are:
get_mu_and_sigmanow ensures the guess of a planet separation is larger than 1xFWHMget_mu_and_sigma:radius_intcan't be negative anymoreget_mu_and_sigma: calculation for mu and sigma uses an annulus that is better within the vicinity of the planet separationseeing_from_headervery simple and extremely fast function to measure the seeing over a list of FITS files (e.g. a night of observations). Could be expanded to include wind speed.derotation.py: np.nan_to_num is performed on the output array rather than making a copy of itget_snr: the snr vs. npc plot now only plots integer values for npc on the x axis (no more 1.5 npc etc.)dist: function now just uses np.hypotbad_frames.py: moved all imports to the top of filebad_frames.py: DAOStarFinder is now a lazy import. This was by far the slowest and generally added 2seconds to an initial import of any VIP function (benchmarked withtuna)