Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for new behaviour of photutils.detect_sources (photutils version>0.7) in roc.compute_binary_map #616

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

VChristiaens
Copy link
Contributor

@VChristiaens VChristiaens commented Aug 18, 2023

also includes some auto-linting in other files.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023

Codecov Report

Merging #616 (aef1e24) into master (61cfa53) will decrease coverage by 0.08%.
The diff coverage is 46.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
- Coverage   57.61%   57.53%   -0.08%     
==========================================
  Files          67       67              
  Lines       13461    13471      +10     
==========================================
- Hits         7755     7750       -5     
- Misses       5706     5721      +15     
Files Changed Coverage Δ
vip_hci/fm/negfc_mcmc.py 70.37% <ø> (+0.16%) ⬆️
vip_hci/fm/negfc_nested.py 58.06% <ø> (ø)
vip_hci/metrics/detection.py 63.88% <ø> (ø)
vip_hci/metrics/roc.py 9.01% <0.00%> (-0.32%) ⬇️
vip_hci/preproc/badpixremoval.py 56.51% <ø> (ø)
vip_hci/var/fit_2d.py 52.21% <ø> (ø)
vip_hci/fm/negfc_simplex.py 86.82% <100.00%> (+0.21%) ⬆️
vip_hci/var/shapes.py 70.11% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VChristiaens VChristiaens merged commit ffa79a7 into vortex-exoplanet:master Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants