Annular Temporal PCA #584
Merged
Annular Temporal PCA #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Compatibe with ADI and ASDI - Temporal PCs computed OUTSIDE the annulus. - ASDI: First PCA exploiting spectral variability is unchanged. Left_eigv only accounts for PCA exploiting angular diversity.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 63.55% 63.70% +0.15%
==========================================
Files 56 56
Lines 12189 12224 +35
==========================================
+ Hits 7746 7787 +41
+ Misses 4443 4437 -6
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Great! Thanks a lot @Sand-jrd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annular temporal PCA : Each annulus is projected onto the time pc's computed using pixels OUTSIDE this annulus.
Mode ASDI : Only the second PCA (the one leveraging angular diversity use the time pc's)
