Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring crosscheck oop #580

Merged
merged 6 commits into from
Mar 10, 2023
Merged

Refactoring crosscheck oop #580

merged 6 commits into from
Mar 10, 2023

Conversation

Eixalde
Copy link
Contributor

@Eixalde Eixalde commented Mar 10, 2023

  • Renamed existing OOP modules (as suggested in Rename HCIPostProcAlgo and HCIDataset #248 )
  • Crosschecked parameters between procedural functions and their OOP equivalent
  • Updated doc when necessary
  • Fixed an infinite loop bug affecting attribute calculations (used for snr map calculations, amongst many)
  • Fixed various disparities between procedural and OOP results

@VChristiaens VChristiaens merged commit e1dc038 into vortex-exoplanet:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Eixalde @VChristiaens