Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of a display error for the disk forward modelling #551

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

jmilou
Copy link
Contributor

@jmilou jmilou commented Aug 2, 2022

No description provided.

jmilou added 2 commits August 2, 2022 11:24
The information on the location of the peak volume density for a disk was wrong. This change corrects the bug
@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2022

Codecov Report

Merging #551 (00dbd47) into master (62a7c6d) will increase coverage by 2.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
+ Coverage   62.16%   64.30%   +2.13%     
==========================================
  Files          56       56              
  Lines       11420    11692     +272     
==========================================
+ Hits         7099     7518     +419     
+ Misses       4321     4174     -147     
Impacted Files Coverage Δ
vip_hci/fm/scattered_light_disk.py 68.23% <100.00%> (+0.13%) ⬆️
vip_hci/fm/negfc_speckle_noise.py 59.47% <0.00%> (-12.27%) ⬇️
vip_hci/metrics/roc.py 9.33% <0.00%> (-4.60%) ⬇️
vip_hci/var/fit_2d.py 51.95% <0.00%> (-3.07%) ⬇️
vip_hci/fm/negfc_simplex.py 86.61% <0.00%> (-1.10%) ⬇️
vip_hci/fm/fakecomp.py 65.85% <0.00%> (-0.29%) ⬇️
vip_hci/fm/negfc_fmerit.py 78.86% <0.00%> (-0.11%) ⬇️
vip_hci/var/iuwt.py 33.33% <0.00%> (ø)
vip_hci/fits/fits.py 45.45% <0.00%> (ø)
... and 37 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@VChristiaens VChristiaens merged commit 8608715 into vortex-exoplanet:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants