Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: require pyo3>=0.23 #56

Merged
merged 3 commits into from
Nov 24, 2024
Merged

feat: require pyo3>=0.23 #56

merged 3 commits into from
Nov 24, 2024

Conversation

mkniewallner
Copy link
Contributor

Migration guide: https://pyo3.rs/v0.23.0/migration.html#from-022-to-023

Alternative to #55 that completely drops support for 0.21 and 0.22 and move away from the deprecated methods.

@mkniewallner mkniewallner marked this pull request as ready for review November 17, 2024 13:46
@juntyr
Copy link

juntyr commented Nov 22, 2024

+1

Copy link
Owner

@vorner vorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with the minor detail of formatting.

src/lib.rs Outdated Show resolved Hide resolved
@vorner
Copy link
Owner

vorner commented Nov 23, 2024

Hmm, what do you think about this CI failure?

https://github.com/vorner/pyo3-log/actions/runs/11987259318/job/33425803070?pr=56 (the Build with minimal supported versions; unfortunately, it seems impossible to link specific build). The others are apparently some CI rot that's obviously unrelated to the changes :-|.

I suspect the problem is not this crate's side, but maybe another set of eyes to confirm 😇

@juntyr
Copy link

juntyr commented Nov 24, 2024

Hmm, what do you think about this CI failure?

https://github.com/vorner/pyo3-log/actions/runs/11987259318/job/33425803070?pr=56 (the Build with minimal supported versions; unfortunately, it seems impossible to link specific build). The others are apparently some CI rot that's obviously unrelated to the changes :-|.

I suspect the problem is not this crate's side, but maybe another set of eyes to confirm 😇

pyo3 v0.23.0 was yanked, so I think the minimum version build fails because it tries to use this version (I had the same issue in my CI). You could try using the version bound >=0.23.1, <0.24

@vorner vorner merged commit 5d76c34 into vorner:main Nov 24, 2024
38 of 51 checks passed
@vorner
Copy link
Owner

vorner commented Nov 24, 2024

Thanks, published.

@mkniewallner mkniewallner deleted the feat/PyO3-0.23 branch November 27, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants