-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to pyo3 0.21 #45
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 26.57% 26.38% -0.19%
==========================================
Files 1 1
Lines 143 144 +1
==========================================
Hits 38 38
- Misses 105 106 +1
|
Apart from the existing comment, it seems the update to the minimal pyo3 version also requires newer rustc due to newer needed edition in some transitive dependencies. Can you also update the CI and the rust-version in the Cargo.toml? |
I tested this on my project and I think this PR is good to go? The only issue is the coverage report which looks kind of squirrelly to me--I can't understand why it's reporting those lines are newly uncovered. |
Hi @ all, just stumbled upon this issue and this PR, is there anything I can do to push this PR forward? best |
I think that the best we can do is a friendly ping to @vorner |
Ups, sorry… I've had too much other things to do, I've merged and released it now. |
@vorner thanks, for merging and for providing the library 👍 ! |
This also makes the lowest supported version to 0.21 to migrate to the new
Bound
API.Closes #48