Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pyo3 0.21 #45

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Update to pyo3 0.21 #45

merged 1 commit into from
Apr 21, 2024

Conversation

a1phyr
Copy link
Contributor

@a1phyr a1phyr commented Mar 26, 2024

This also makes the lowest supported version to 0.21 to migrate to the new Bound API.

Closes #48

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 26.38%. Comparing base (615d8f3) to head (d17a02a).
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   26.57%   26.38%   -0.19%     
==========================================
  Files           1        1              
  Lines         143      144       +1     
==========================================
  Hits           38       38              
- Misses        105      106       +1     
Files Coverage Δ
src/lib.rs 26.38% <11.11%> (-0.19%) ⬇️

src/lib.rs Outdated Show resolved Hide resolved
@vorner
Copy link
Owner

vorner commented Mar 30, 2024

Apart from the existing comment, it seems the update to the minimal pyo3 version also requires newer rustc due to newer needed edition in some transitive dependencies. Can you also update the CI and the rust-version in the Cargo.toml?

@jamestwebber
Copy link

I tested this on my project and I think this PR is good to go? The only issue is the coverage report which looks kind of squirrelly to me--I can't understand why it's reporting those lines are newly uncovered.

@Nicoretti
Copy link

Nicoretti commented Apr 17, 2024

Hi @ all,

just stumbled upon this issue and this PR, is there anything I can do to push this PR forward?

best
Nico

@a1phyr
Copy link
Contributor Author

a1phyr commented Apr 19, 2024

I think that the best we can do is a friendly ping to @vorner

@vorner vorner merged commit 36254e2 into vorner:main Apr 21, 2024
52 of 53 checks passed
@vorner
Copy link
Owner

vorner commented Apr 21, 2024

Ups, sorry… I've had too much other things to do, I've merged and released it now.

@Nicoretti
Copy link

Nicoretti commented Apr 22, 2024

@vorner thanks, for merging and for providing the library 👍 !

@a1phyr a1phyr deleted the pyo3_0.21 branch June 25, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with pyo 0.21.1
5 participants