Straightforward fix for on_character_rotate error #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a cast that converts float to double when obtaining current character rotation, for the character rotation calculation.
This is a very simple fix, if anything more premeditated is to be done, this PR can be interpreted as an issue, for the project currently gives an error with this for everyone pulling it for the fist time, I thought I'd add this easy fix. There may be better solutions, I just didn't investigate further.
Someone suggested the use of real_t (godot macro for either float or double depending on a certain extension compile option), but I'm not convinced that A. That would be a proper solution, B. If it is a proper solution, it would potentially make sense in other areas of the project, even for general use when developing godot-cpp applications. (I don't know enough about real_t use cases to make this decision right now).