Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CMakeLists.txt comments. #23

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Added CMakeLists.txt comments. #23

merged 2 commits into from
Dec 1, 2024

Conversation

Mangonels
Copy link
Collaborator

I wrote these comments on my own project and passed them over to roguelite.

@Mangonels Mangonels requested a review from vorlac November 28, 2024 20:49
Copy link
Owner

@vorlac vorlac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i just made a few small edits and re-added one of the target property options that was accidentally dropped from the cmakelists.txt

@vorlac vorlac merged commit d81aff4 into main Dec 1, 2024
2 checks passed
@vorlac vorlac deleted the cmakelists-comment-overhaul branch December 1, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants