This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Cert expired checker #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkrizek
reviewed
Apr 3, 2021
There was a problem hiding this comment.
@orbitalturtle This looks awesome and I love how you reformatted the ZeroSSL service. Few comments for the initial review. I can start testing once we straighten those out.
Also looks like it could use a make fmt
lnd.go
Outdated
| func CheckForExpiredCert(certprovider certprovider.CertProvider, certId string) bool { | ||
| cert, err := certprovider.GetCert(certId) | ||
| if err != nil { | ||
| fmt.Errorf("error retrieving ZeroSSL certificate: %v", err) |
There was a problem hiding this comment.
Do we need a return here? Maybe if there's an error return false
lnd.go
Outdated
|
|
||
| // CheckForExpiredCert finds whether the TLS certificate is expiring soon. | ||
| func CheckForExpiredCert(certprovider certprovider.CertProvider, certId string) bool { | ||
| cert, err := certprovider.GetCert(certId) |
There was a problem hiding this comment.
Interesting choice calling to ZeroSSL to check the expiration date. I actually didn't even think about that. My approach would have been to read the tls.cert from disk and check it's expiration date from that. What's your opinion on one versus the other? I think I'm slightly worried that this could get out of step with what the API returns and what the certificate actually is. That might be a super rare case, but could be a crazy happening nonetheless.
There was a problem hiding this comment.
Ohh that's a good point. Let's read from disk to be safe. Also just in terms of the API potentially going down sometimes and whatnot
lnd.go
Outdated
| keyBytes, err = lnencrypt.DecryptPayloadFromReader(reader, activeChainControl.KeyRing) | ||
| if err != nil { | ||
| ltndLog.Error(err) | ||
| // return err |
There was a problem hiding this comment.
I see you commented out the error, should we return errors from this function?
lnd.go
Outdated
| if err != nil { | ||
| ltndLog.Error("Failed to revoke temporary certifiate:") | ||
| ltndLog.Error(err) | ||
| } | ||
| // Switch the server's TLS certificate to the persisntent one | ||
| // Switch the server's TLS certificate to the persistent one | ||
| err = tlsReloader.AttemptReload(certBytes, keyBytes) |
There was a problem hiding this comment.
Should this bit of code be replaced by the new DeleteAndRegenerateCert function? I'm not exactly sure but looks like maybe it can?
|
@gkrizek Thanks for the review! I'll fix those things up. Are you able to give me an example output of the full JSON that the download endpoint gives (https://zerossl.com/documentation/api/download-certificate-inline/)? That'll actually help with one of these changes |
|
Sorry! Forgot about this part. Here's an example response: |
orbitalturtle
force-pushed
the
cert-expired-checker
branch
from
303ec1e
to
dbc68eb
Compare
|
@gkrizek Here's a refreshed version! I believe most of the new code is test-related |
|
Looking over it again I think this look good. I'll test this soon too. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Contribution Guidelines
the positive and negative (error paths) conditions (if applicable)
the bug being fixed to prevent regressions
logging level
go fmtlnrpc/**/*.proto) have been formatted withmake rpc-formatand compiled withmake rpcsample-lnd.conf(the tab character should be counted as 8 characters, not 4, as some IDEs do
per default)
make checkdoes not fail any testsgo vetdoes not report any issuesmake lintdoes not report any new issues that did notalready exist
cases it can be justifiable to violate this condition. In that case, the
reason should be stated in the commit message.