Use attohttpc instead of reqwest for fetching #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
reqwest
in Volta, since all of our HTTP access is synchronous.reqwest
provides a synchronous API, it still uses the async engine and task executor (tokio
) under the hood.attohttpc
is a purely-synchronous HTTP Request client with a very similar API toreqwest
.Changes
reqwest
and addedattohttpc
to all of the appropriate crates.hyperx
to1.0.0
, to match the transitive dependency onhttp
attohttpc
s slightly different APINotes
volta
, and a ~30% reduction in the executable size forvolta-shim
.cargo build --release
by ~ 22% (from 6m12s down to 4m50s).