Use lockfile when installing cargo-wix in CI #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing a package using `cargo install`, by default it ignores the lockfile for that package and installs the latest relevant dependency versions. This can be overridden by using the `--locked` flag. Using an unlocked install is causing issues in CI, because we have our Rust version pinned to a version that is older than the MSRV for some of `cargo-wix`'s dependencies. Switching to a locked install means that the dependency versions will be repeatable and so we shouldn't have issues with Rust version mismatches.
chriskrycho
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
When installing a package using
cargo install, by default it ignores the lockfile for that package and installs the latest relevant dependency versions. This can be overridden by using the--lockedflag.Using an unlocked install is causing issues in CI, because we have our Rust version pinned to a version that is older than the MSRV for some of
cargo-wix's dependencies. Switching to a locked install means that the dependency versions will be repeatable and so we shouldn't have issues with Rust version mismatches.Changes
cargo wixto use the--lockedflagTested
Notes
--lockedflag.