Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of the field missing in JOSS paper #134

Closed
1 task
ojeda-e opened this issue Dec 9, 2021 · 3 comments · Fixed by #135
Closed
1 task

State of the field missing in JOSS paper #134

ojeda-e opened this issue Dec 9, 2021 · 3 comments · Fixed by #135
Labels
joss-review OpenCADD-KLIFS JOSS review

Comments

@ojeda-e
Copy link
Contributor

ojeda-e commented Dec 9, 2021

The JOSS paper should include a comparison of openCADD-KLIFS to other commonly-used packages. Here are some questions that may help to add a couple of lines to the state of the field in your paper:

  • Are there any other similar packages to openCADD-KLIFS? If yes, how is openCADD-KLIFS different?
  • Is this package the open-source version of proprietary software?
  • Is openCADD-KLIFS offering a unique solution to fetch data? Is openCADD-KLIFS the only automated package to fetch KLIFS data?
  • How was the process of fetching KLIFS data before openCADD? How is the package making this process different/better/faster?

To fix this issue:

  • Add a state of the field in the paper, where a comparison to other packages is offered to the reader.

REF: openjournals/joss-reviews#3951

@dominiquesydow
Copy link
Contributor

@ojeda-e thanks a lot for the pointers! My apologies for the delay on my end; I will have drafted an update by tomorrow.

@ojeda-e
Copy link
Contributor Author

ojeda-e commented Dec 15, 2021

Thanks for letting me know @dominiquesydow. Can't wait to read the missing parts to finish the review! :)

@dominiquesydow
Copy link
Contributor

Hi @ojeda-e,

Thanks again for your input on the manuscript!
Please have a look at the revised version:
openjournals/joss-reviews#3951 (comment)

I have merged your comments with those from issue #133 in PR #135.

@dominiquesydow dominiquesydow added the joss-review OpenCADD-KLIFS JOSS review label Dec 21, 2021
dominiquesydow added a commit that referenced this issue Dec 21, 2021
Revise OpenCADD-KLIFS manuscript (issues #133 and #134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
joss-review OpenCADD-KLIFS JOSS review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants