Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mlflow, allow forward to have different batch size, compute more metrics #74

Merged
merged 17 commits into from
Jan 2, 2025

Conversation

fzyzcjy
Copy link
Contributor

@fzyzcjy fzyzcjy commented Jan 2, 2025

Hi, this is a tiny PR to

  • support mlflow in addition to existing wandb and console
  • allow critic forward to have different batch size than critic update (if I understand correctly, usually forward can have larger one)
  • expose more metrics, mainly the "timing per token"

Example outputs of mlflow:

image

Example outputs of the new metrics:

image

@fzyzcjy fzyzcjy marked this pull request as ready for review January 2, 2025 06:15
@fzyzcjy fzyzcjy changed the title Compute more metrics Support Mlflow and compute more metrics Jan 2, 2025
@fzyzcjy fzyzcjy changed the title Support Mlflow and compute more metrics Support Mlflow, allow forward has different batch size, compute more metrics Jan 2, 2025
@fzyzcjy fzyzcjy changed the title Support Mlflow, allow forward has different batch size, compute more metrics Support Mlflow, allow forward to have different batch size, compute more metrics Jan 2, 2025
@PeterSH6
Copy link
Collaborator

PeterSH6 commented Jan 2, 2025

LGTM!

@PeterSH6 PeterSH6 merged commit 2856be4 into volcengine:main Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants