Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug：无法保存checkpoint，报错 #174

Merged
merged 2 commits into from
Jan 31, 2025
Merged

fix bug：无法保存checkpoint，报错 #174

merged 2 commits into from
Jan 31, 2025
+1 −1

Conversation

dignfei
Copy link
Contributor

@dignfei dignfei commented Jan 30, 2025

image

eric-haibin-lin
eric-haibin-lin approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the fix!

@eric-haibin-lin eric-haibin-lin merged commit 679798c into volcengine:main Jan 31, 2025
@WeiXiongUST WeiXiongUST mentioned this pull request Feb 4, 2025
Closed
Chendong98 pushed a commit to Chendong98/verl that referenced this pull request Feb 4, 2025
@dignfei @eric-haibin-lin @Chendong98
fix bug：fix checkpoint save with existing dirs (volcengine#174)
947fabb 
![image](https://github.com/user-attachments/assets/f0bae990-a4ef-49da-aa1e-58894b41db5f)

---------

Co-authored-by: HL <linhaibin.eric@gmail.com>
@WeiXiongUST WeiXiongUST mentioned this pull request Feb 4, 2025
Merged
vermouth1992 pushed a commit that referenced this pull request Feb 5, 2025
@WeiXiongUST
fix critic save error (#199)
4669ab9 
This PR is similar to PR #174 but
fix the critic save error

I move the old PR to this one due to some redundant commit
as12138 pushed a commit to as12138/verl that referenced this pull request Feb 20, 2025
@dignfei @eric-haibin-lin @as12138
fix bug：fix checkpoint save with existing dirs (volcengine#174)
8829c80 
![image](https://github.com/user-attachments/assets/f0bae990-a4ef-49da-aa1e-58894b41db5f)

---------

Co-authored-by: HL <linhaibin.eric@gmail.com>
as12138 pushed a commit to as12138/verl that referenced this pull request Feb 20, 2025
@WeiXiongUST @as12138
fix critic save error (volcengine#199)
6aa7405 
This PR is similar to PR volcengine#174 but
fix the critic save error

I move the old PR to this one due to some redundant commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dignfei @eric-haibin-lin