Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] - Optimized Images #306

Merged
merged 1 commit into from
Aug 10, 2023
Merged

[Feat] - Optimized Images #306

merged 1 commit into from
Aug 10, 2023

Conversation

krishnasvp
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    /kind cleanup

  • What this PR does / why we need it:

  • Optimizes the images to save ~10mb across the website

@krishnasvp
Optimized Images
605deaa 
Signed-off-by: Krishna Sivapothanathan <krishnasivapothanathan@gmail.com>
@volcano-sh-bot
Copy link
Collaborator

Welcome @krishnasvp!

It looks like this is your first PR to volcano-sh/website 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 3, 2023
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 3, 2023
@krishnasvp
Copy link
Contributor Author

/assign

Arhell
Arhell reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2023
@Arhell Arhell removed their assignment Aug 4, 2023
kevin-wangzefeng
kevin-wangzefeng reviewed Aug 10, 2023
View reviewed changes
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2023
@volcano-sh-bot volcano-sh-bot merged commit f722e2f into volcano-sh:master Aug 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@Arhell Arhell Arhell left review comments

Assignees

@krishnasvp krishnasvp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krishnasvp @volcano-sh-bot @kevin-wangzefeng @Arhell