Clean code #92
Merged
Clean code #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyLike
reviewed
Apr 18, 2019
| AddFunc: cc.addCommand, | ||
| }, | ||
| cc.cmdInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{ | ||
| AddFunc: cc.addCommand, |
There was a problem hiding this comment.
Can we keep the ControllerdBy filter logic here?
There was a problem hiding this comment.
Is there any command resource not managed by volcano?
TommyLike
reviewed
Apr 18, 2019
| DeleteFunc: cc.deletePod, | ||
| }, | ||
| podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{ | ||
| AddFunc: cc.addPod, |
There was a problem hiding this comment.
This is not needed, we already have many other checks in event handlers, like this
taskName, found := pod.Annotations[vkbatchv1.TaskSpecKey]
if !found {
glog.Infof("Failed to find taskName of Pod <%s/%s>, skipping",
pod.Namespace, pod.Name)
return
}
jobName, found := pod.Annotations[vkbatchv1.JobNameKey]
if !found {
glog.Infof("Failed to find jobName of Pod <%s/%s>, skipping",
pod.Namespace, pod.Name)
return
}
version, found := pod.Annotations[vkbatchv1.JobVersion]
if !found {
glog.Infof("Failed to find jobVersion of Pod <%s/%s>, skipping",
pod.Namespace, pod.Name)
return
}
There was a problem hiding this comment.
Which is faster, just asking.
There was a problem hiding this comment.
The above check is inevitable, so it's enough, if we check twice, then absolutely double time wasting
TommyLike
reviewed
Apr 18, 2019
| errs = append(errs, err) | ||
| continue | ||
| } | ||
| if err := cc.deleteJobPod(job.Name, pod); err != nil { |
|
/lgtm |
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue removing some redundant code