Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pdb support #654

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Remove pdb support #654

merged 1 commit into from
Dec 30, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

Actually the pdb feature can not work well. Remove it.

Fixes: #628

@jianxingzhe Can you test with this pr?

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f6bee5b0-2ae3-11ea-b3af-3392aa6c8569

@jianxingzhe
Copy link

Actually the pdb feature can not work well. Remove it.

Fixes: #628

@jianxingzhe Can you test with this pr?

the volcano scheduler start successfully in our cluster with this pr. thank you very much.

kubectl get pod -n volcano-system
NAME                                   READY   STATUS      RESTARTS   AGE
volcano-admission-fd4b955cf-2dxkw      1/1     Running     0          29h
volcano-admission-init-fngph           0/1     Completed   0          29h
volcano-controllers-57864457d4-tzxqm   1/1     Running     0          29h
volcano-scheduler-675c5ff757-mf657     1/1     Running     0          6m51s

@k82cn
Copy link
Member

k82cn commented Dec 30, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2019
@volcano-sh-bot volcano-sh-bot merged commit 8a7680a into volcano-sh:master Dec 30, 2019
@hzxuzhonghu hzxuzhonghu deleted the pdb branch December 30, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volcano-scheduler start failed
5 participants