Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the the Getting started link in contribute.md #633

Merged
merged 1 commit into from
Dec 26, 2019

Conversation

ruiyinchen
Copy link
Contributor

fix the the Getting started link

fix the the # Getting started link
@volcano-sh-bot
Copy link
Contributor

Welcome @ruiyinchen!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2019
@TravisBuddy
Copy link

Hey @ruiyinchen,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0eb11910-234e-11ea-8e2a-07cdc06d0399

@@ -31,8 +31,8 @@ The goal of the community is to develop a volcano system which is useful for run

# Getting started

- Read the [get started](docs/development/perepare-for-development.md) for developing code for Volcano
- Read the [setup](docs/development/development.md) for build/deploy instructions.
- Read the [get started](https://github.com/volcano-sh/volcano/blob/master/docs/development/prepare-for-development.md) for developing code for Volcano
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to keep relative path as we may publish those doc by branch.

@k82cn
Copy link
Member

k82cn commented Dec 21, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, ruiyinchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2019
@k82cn
Copy link
Member

k82cn commented Dec 26, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 26, 2019
@volcano-sh-bot volcano-sh-bot merged commit 59f4d72 into volcano-sh:master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants