Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support networkpolicy #552

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Conversation

hzxuzhonghu
Copy link
Collaborator

This is for the sake of the security, added networkpolicy to allow access from only groups of pods belong to the same job and prevent access from external.

Note: networkpolicy depends on CNI plugin, only takes effect when cni supports it.

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 26, 2019
@hzxuzhonghu
Copy link
Collaborator Author

/assign @k82cn

@hzxuzhonghu
Copy link
Collaborator Author

I will add test later if this is feasible.

@k82cn
Copy link
Member

k82cn commented Nov 26, 2019

LGTM overall

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: f30d7ad0-1026-11ea-a65a-5f455ab5a299

@k82cn
Copy link
Member

k82cn commented Nov 27, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2019
@volcano-sh-bot volcano-sh-bot merged commit 89e93e2 into volcano-sh:master Nov 27, 2019
@hzxuzhonghu hzxuzhonghu deleted the network-policy branch November 27, 2019 02:23
@@ -97,6 +98,11 @@ func (sp *servicePlugin) OnJobAdd(job *batch.Job) error {
return err
}

// TODO: maybe add a flag
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hzxuzhonghu can you pls add flag for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalfos Yeah, anyway i want to know your use case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hzxuzhonghu I already implemented it through calicoctl I want to avoid conflicts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm... let's add a flag to this plugin :)

@dalfos
Copy link

dalfos commented Dec 17, 2019

Hi @hzxuzhonghu and @k82cn should I open issue for discussed flag?

@k82cn
Copy link
Member

k82cn commented Dec 17, 2019

Hi @hzxuzhonghu and @k82cn should I open issue for discussed flag?

That's ok to me, please go ahead to open an issue/pr for that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants