Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPI example and tests #51

Merged
merged 2 commits into from
Mar 30, 2019
Merged

Add MPI example and tests #51

merged 2 commits into from
Mar 30, 2019

Conversation

TommyLike
Copy link
Contributor

For #42

metadata:
name: lm-mpi-job
spec:
minAvailable: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minAvailable should be 3 to run whole job.

@@ -0,0 +1,17 @@
FROM ubuntu:16.04
MAINTAINER volcano <maintainer@volcano.sh>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let us this email: volcano-sh@googlegroups.com

@jeefy
Copy link
Contributor

jeefy commented Mar 29, 2019

That's what I call timing: kubernetes-retired/kube-batch#688

I'm worried my review is going to be biased since I just did this PR for Kube-Batch, so keep that in mind. :)

  • This assumes that the job will use your container. It might be better to support people bringing their own images, so long as they have MPI support.
  • While I actually like not requiring a CRD, I feel like this approach leads to poor UX
    • This requires a user to break out the executor from the workers manually. The job definition becomes bloated and redundant because of this.
    • For longer running MPI jobs, it makes sense to wrap them in RBAC and, eventually, NetworkPolicies. This should be done with a CRD and operator logic, and cleanup will be easy since we can set OwnerReferences to that new CRD object
  • This code is so much cleaner than mine 😂
  • I love that you used kind

I'm the new guy looking at this, and I'm not sure the direction or end-state y'all are looking to achieve, so take these comments as uninformed. :)

@k82cn
Copy link
Member

k82cn commented Mar 30, 2019

This assumes that the job will use your container.

Nop, user can build container on demand, with open-mpi & ssh support. For kubectl, it try to avoid unnecessary access to api-server; and that'll be great if you can build a 'kubectl' plugin for mpi job to use.

@k82cn
Copy link
Member

k82cn commented Mar 30, 2019

btw, let's discuss the detail at #42 ; I'd like to get this merged firstly for next step :)

@k82cn k82cn merged commit b4c84f6 into master Mar 30, 2019
@k82cn k82cn deleted the feature/support-mpi branch March 30, 2019 02:07
wangyuqing4 pushed a commit to wangyuqing4/volcano-1 that referenced this pull request Apr 30, 2019
[Issue volcano-sh#51] [BUG2019040200210] DeletedFinalStateUnknown should be handled correctly

DeletedFinalStateUnknown should be handled correctly

Issues info:
Issue ID: 51
Title: [BUG2019040200210] job已经被删除的情况下,pod反复重新拉起被kill的操作
Issue url: CBU-PaaS/Community/volcano/volcano#51


See merge request CBU-PaaS/Community/volcano/volcano!84
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants