Pod Scheduling Readiness Draft #3612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ykcai-daniel <1155141377@link.cuhk.edu.hk>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
size/L
googs1025
reviewed
Jul 19, 2024
| @@ -171,4 +171,5 @@ replace ( | |||
| k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.30.2 | |||
| k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.30.2 | |||
| k8s.io/sample-controller => k8s.io/sample-controller v0.30.2 | |||
| volcano.sh/apis => github.com/ykcai-daniel/apis v0.1.0 | |||
There was a problem hiding this comment.
Is this replacement necessary?
googs1025
reviewed
Jul 19, 2024
| @@ -339,6 +339,7 @@ type JobInfo struct { | |||
| // * value means workload can use all the revocable node for during node active revocable time. | |||
| RevocableZone string | |||
| Budget *DisruptionBudget | |||
|
|
|||
googs1025
reviewed
Jul 19, 2024
| func (ji* JobInfo) SchedulingGated() bool{ | ||
| for _,task:= range ji.Tasks{ | ||
| if len(task.Pod.Spec.SchedulingGates) > 0 { | ||
| ji.PodGroup.Status.Phase=scheduling.PodGroupSchGated |
There was a problem hiding this comment.
Please adjust the indentation of the code. The same as above for other places
googs1025
reviewed
Jul 19, 2024
| slot1 := corev1.ResourceList{ | ||
| corev1.ResourceCPU: resource.MustParse("1000m"), | ||
| corev1.ResourceMemory: resource.MustParse("1024Mi")} | ||
| // slot2 := corev1.ResourceList{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new state PodGroupSchGated and modified scheduler actions. More details in #3581