Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TaskComplete in LifecyclePolicy #36

Merged
merged 4 commits into from
Mar 24, 2019

Conversation

TommyLike
Copy link
Contributor

Now volcano support setting new lifecyclepolicy regarding Task Complete Event:

{
	Action: vkv1.CompleteJobAction,
	Event:  vkv1.TaskCompletedEvent,
},

for #26

@k82cn
Copy link
Member

k82cn commented Mar 21, 2019

LGTM overall, just some comments on code refactor :)

@k82cn
Copy link
Member

k82cn commented Mar 22, 2019

please fix gofmt error firstly.

@k82cn k82cn merged commit fc95697 into master Mar 24, 2019
@k82cn k82cn deleted the feature/support_task_level_lifecycle branch March 24, 2019 01:09
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Apr 30, 2019
yolgun added a commit to yolgun/volcano that referenced this pull request Sep 16, 2022
Co-authored-by: Yunus Olgun <yunuso@spotify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants