Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix k8s.io/dynamic-resource-allocation go mod not found err #3272

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

Monokaix
Copy link
Member

@Monokaix Monokaix commented Dec 18, 2023

k8s.io/dynamic-resource-allocation is imported in k8s v1.27, and should also be replaced with v0.27 like other sub libraries, or error will occur when execute go list -json command:
"D:\Program Files\Go\bin\go.exe" list -modfile=D:/go/src/volcano\go.mod -m -json -mod=mod all #gosetup go: k8s.io/dynamic-resource-allocation@v0.0.0: reading https://cmc.centralrepo.rnd.huawei.com/artifactory/go-central-repo/k8s.io/dynamic-resource-allocation/@v/v0.0.0.info: 404

Signed-off-by: Xuzheng Chang <changxuzheng@huawei.com>
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 29, 2023
@wangyang0616
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot merged commit ea58fa8 into volcano-sh:release-1.8 Dec 29, 2023
9 checks passed
@Monokaix Monokaix deleted the 1.8-go-mod branch January 8, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants